More explicit testing of pickling of user defined symbol#525
Closed
bjodah wants to merge 4 commits intosymengine:masterfrom
Closed
More explicit testing of pickling of user defined symbol#525bjodah wants to merge 4 commits intosymengine:masterfrom
bjodah wants to merge 4 commits intosymengine:masterfrom
Conversation
551c16e to
f7f0293
Compare
5df2f13 to
87ff8a3
Compare
Contributor
Author
|
So when using: we get this pytest failure consistently: ________________________________ test_pysymbol _________________________________
def test_pysymbol():
a = MySymbol("hello", attr=1)
b = pickle.loads(pickle.dumps(a + 2)) - 2
c = MySymbol("hello", attr=-1)
try:
> assert a == b
E assert hello == hello
symengine/tests/test_pickling.py:43: AssertionError(b is no longer a |
Contributor
Author
|
Nevermind, here's the reason: symengine.py/symengine/lib/pywrapper.cpp Line 327 in 4f0775a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft-PR tracks symengine/symengine#2129